diff options
| author | Edward Hervey <edward@centricular.com> | 2023-04-17 09:28:43 +0200 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2023-04-17 10:02:09 +0100 |
| commit | f97e0d9777346e95c7f617ff719689f444ee259c (patch) | |
| tree | 26e5b9829571f334cca9247d33e9fff7bc27e26b | |
| parent | 026e82361b999d94e89548b18ebf36dcb3b3a743 (diff) | |
qtdemux: Fix av1C parsing
This is a regression introduced by
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3882
The av1c codec configuration parsing would always fail due to an off-by-one
error, the content of an atom starting at offset 8 (i.e. the 9th byte) and not
9 (the 10th byte).
Also introduce a break in order to not get stray warnings
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4434>
| -rw-r--r-- | subprojects/gst-plugins-good/gst/isomp4/qtdemux.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c index 1a8ecb9055..92a17f686b 100644 --- a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c +++ b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c @@ -11999,7 +11999,7 @@ qtdemux_parse_trak (GstQTDemux * qtdemux, GNode * trak) * rest: OBUs. */ - switch (av1_data[9]) { + switch (av1_data[8]) { case 0x81:{ guint8 pres_delay_field; @@ -12020,10 +12020,11 @@ qtdemux_parse_trak (GstQTDemux * qtdemux, GNode * trak) gst_caps_set_simple (entry->caps, "codec_data", GST_TYPE_BUFFER, buf, NULL); gst_buffer_unref (buf); + break; } default: - GST_WARNING ("Unknown version %d of av1C box", - av1_data[9]); + GST_WARNING ("Unknown version 0x%02x of av1C box", + av1_data[8]); break; } |