From 2234480233eccf1b110232b1c8f061dfbc7b32e7 Mon Sep 17 00:00:00 2001
From: David Schleef <david.schleef@rd.io>
Date: Tue, 5 Nov 2013 23:02:15 -0800
Subject: transaction: refactor timekeeping

---
 gst-streaming-server/gss-log.c         | 12 +++++++++---
 gst-streaming-server/gss-transaction.c | 31 ++++++++++++++++++++++---------
 gst-streaming-server/gss-transaction.h |  7 +++----
 3 files changed, 34 insertions(+), 16 deletions(-)

diff --git a/gst-streaming-server/gss-log.c b/gst-streaming-server/gss-log.c
index 83a44da..dbab626 100644
--- a/gst-streaming-server/gss-log.c
+++ b/gst-streaming-server/gss-log.c
@@ -197,13 +197,19 @@ gss_log_transaction (GssTransaction * t)
   } else {
     char *uri;
     uri = soup_uri_to_string (soup_message_get_uri (t->msg), TRUE);
-    s = g_strdup_printf ("%s %s %s \"%s\" %d %" G_GSIZE_FORMAT " %"
-        G_GSIZE_FORMAT " %" G_GSIZE_FORMAT " %" G_GUINT64_FORMAT " %s",
+    s = g_strdup_printf ("%s %s %s \"%s\" %d %" G_GSIZE_FORMAT
+        " %" G_GUINT64_FORMAT
+        " %" G_GUINT64_FORMAT
+        " %" G_GUINT64_FORMAT
+        " %" G_GSIZE_FORMAT
+        " %" G_GSIZE_FORMAT
+        " %s",
         addr,
         dt, t->msg->method,
         uri,
         t->msg->status_code,
-        t->msg->response_body->length, t->finish_time - t->start_time,
+        t->msg->response_body->length,
+        t->sync_process_time, t->async_process_time, t->total_time,
         t->start, t->end, t->debug_message ? t->debug_message : "");
     g_free (uri);
   }
diff --git a/gst-streaming-server/gss-transaction.c b/gst-streaming-server/gss-transaction.c
index 1bdf333..04fd89e 100644
--- a/gst-streaming-server/gss-transaction.c
+++ b/gst-streaming-server/gss-transaction.c
@@ -28,6 +28,8 @@
 #include <json-glib/json-glib.h>
 
 static void gss_transaction_finalize (GssTransaction * t, SoupMessage * msg);
+static void gss_transaction_wrote_headers (SoupMessage * msg,
+    GssTransaction * t);
 static void gss_transaction_finished (SoupMessage * msg, GssTransaction * t);
 
 
@@ -45,8 +47,11 @@ gss_transaction_new (GssServer * server, SoupServer * soupserver,
   transaction->path = path;
   transaction->query = query;
   transaction->client = client;
-  transaction->start_time = g_get_real_time ();
+  transaction->sync_process_time = -g_get_real_time ();
+  transaction->total_time = -g_get_real_time ();
 
+  g_signal_connect (msg, "wrote-headers",
+      G_CALLBACK (gss_transaction_wrote_headers), transaction);
   g_signal_connect (msg, "finished", G_CALLBACK (gss_transaction_finished),
       transaction);
   g_object_weak_ref (G_OBJECT (msg), (GWeakNotify) (gss_transaction_finalize),
@@ -61,17 +66,25 @@ gss_transaction_free (GssTransaction * transaction)
   g_free (transaction);
 }
 
+static void
+gss_transaction_wrote_headers (SoupMessage * msg, GssTransaction * t)
+{
+  if (t->sync_process_time < 0) {
+    t->sync_process_time += g_get_real_time ();
+  }
+}
+
 static void
 gss_transaction_finished (SoupMessage * msg, GssTransaction * t)
 {
-  t->finish_time = g_get_real_time ();
+  t->total_time += g_get_real_time ();
 
   gss_log_transaction (t);
-  if (!t->async && t->finish_time - t->start_time > 1000) {
+  if (t->sync_process_time > 1000) {
     char *uri;
     uri = soup_uri_to_string (soup_message_get_uri (t->msg), TRUE);
-    GST_WARNING ("synchronous transaction too slow: %" G_GUINT64_FORMAT
-        " us, \"%s\"", t->finish_time - t->start_time, uri);
+    GST_WARNING ("synchronous processing too slow: %" G_GUINT64_FORMAT
+        " us, \"%s\"", t->sync_process_time, uri);
     g_free (uri);
   }
   g_object_weak_unref (G_OBJECT (t->msg),
@@ -165,7 +178,6 @@ gss_transaction_delay (GssTransaction * t, int msec)
   new_t = g_malloc0 (sizeof (GssTransaction));
   memcpy (new_t, t, sizeof (GssTransaction));
 
-  t->async = TRUE;
   soup_server_pause_message (t->soupserver, t->msg);
   g_timeout_add (msec, unpause, new_t);
 }
@@ -197,8 +209,10 @@ gss_transaction_async_thread (gpointer unused)
       g_thread_exit (NULL);
     }
 
+    t->async_process_time -= g_get_real_time ();
     if (t->process)
       t->process (t, t->priv);
+    t->async_process_time += g_get_real_time ();
     g_idle_add (gss_transaction_async_finish, t);
   }
   return NULL;
@@ -242,7 +256,8 @@ gss_transaction_process_async (GssTransaction * t,
     _priv_gss_transaction_initialize ();
   }
 
-  t->async = TRUE;
+  t->sync_process_time += g_get_real_time ();
+
   t->process = process;
   t->finish = finish;
   t->priv = priv;
@@ -513,8 +528,6 @@ gss_transaction_dump (GssTransaction * t)
   g_print ("From: %s\n",
       soup_address_get_physical (soup_client_context_get_address (t->client)));
   g_print ("Status: %d\n", t->msg->status_code);
-  g_print ("Response Latency: %" G_GUINT64_FORMAT " us\n",
-      t->completion_time - t->start_time);
   g_print ("Request Headers:\n");
   soup_message_headers_iter_init (&iter, t->msg->request_headers);
   while (soup_message_headers_iter_next (&iter, &name, &value)) {
diff --git a/gst-streaming-server/gss-transaction.h b/gst-streaming-server/gss-transaction.h
index 54bfa18..8dc2358 100644
--- a/gst-streaming-server/gss-transaction.h
+++ b/gst-streaming-server/gss-transaction.h
@@ -45,12 +45,11 @@ struct _GssTransaction {
   GString *script;
   const char *debug_message;
   int id;
-  guint64 start_time;
-  guint64 completion_time;
-  guint64 finish_time;
+  gint64 sync_process_time;
+  gint64 async_process_time;
+  gint64 total_time;
   gsize start, end;
 
-  gboolean async;
   GssTransactionFunc *process;
   GssTransactionFunc *finish;
   gpointer priv;
-- 
cgit v1.2.3