summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThibault Saunier <tsaunier@igalia.com>2019-04-08 16:23:18 -0400
committerThibault Saunier <tsaunier@igalia.com>2019-04-15 17:11:48 -0400
commitcfd5fda38d9e7952558fc04a022ab4989dafdf1f (patch)
treec370bdba9df0fac1ef86ad2f777736de8eb9c06a
parent5c54ba55b7d90bd9ff49a3c31d88b9ae9386e5e7 (diff)
title: Deprecate method that return newly allocated `const gchar*`
This is just plain broken 190643508f14a64e36f085a69de819505e79dadb but we can't do anything about it.
-rw-r--r--ges/ges-title-source.c10
-rw-r--r--tests/check/ges/titles.c7
2 files changed, 8 insertions, 9 deletions
diff --git a/ges/ges-title-source.c b/ges/ges-title-source.c
index be4671e8..f67115bb 100644
--- a/ges/ges-title-source.c
+++ b/ges/ges-title-source.c
@@ -450,7 +450,10 @@ ges_title_source_set_ypos (GESTitleSource * self, gdouble position)
*
* Get the text currently set on the @source.
*
- * Returns: (transfer none): The text currently set on the @source.
+ * Returns: (transfer full): The text currently set on the @source.
+ *
+ * Deprecated: 1.16: Use ges_timeline_element_get_child_property instead
+ * (this actually returns a newly allocated string)
*/
const gchar *
ges_title_source_get_text (GESTitleSource * source)
@@ -469,8 +472,11 @@ ges_title_source_get_text (GESTitleSource * source)
*
* Get the pango font description used by @source.
*
- * Returns: (transfer none): The pango font description used by this
+ * Returns: (transfer full): The pango font description used by this
* @source.
+ *
+ * Deprecated: 1.16: Use ges_timeline_element_get_child_property instead
+ * (this actually returns a newly allocated string)
*/
const gchar *
ges_title_source_get_font_desc (GESTitleSource * source)
diff --git a/tests/check/ges/titles.c b/tests/check/ges/titles.c
index 42a374bc..b9bf4a6e 100644
--- a/tests/check/ges/titles.c
+++ b/tests/check/ges/titles.c
@@ -148,19 +148,12 @@ GST_START_TEST (test_title_source_in_layer)
track_element =
ges_clip_find_track_element (GES_CLIP (source), v, GES_TYPE_TITLE_SOURCE);
- /* Check the text is still the same */
- assert_equals_string (ges_title_source_get_text (GES_TITLE_SOURCE
- (track_element)), "some text");
-
/* test the font-desc property */
g_object_set (source, "font-desc", (gchar *) "sans 72", NULL);
g_object_get (source, "font-desc", &text, NULL);
assert_equals_string ("sans 72", text);
g_free (text);
- assert_equals_string ("sans 72",
- ges_title_source_get_font_desc (GES_TITLE_SOURCE (track_element)));
-
/* test halign and valign */
g_object_set (source, "halignment", (gint)
GES_TEXT_HALIGN_LEFT, "valignment", (gint) GES_TEXT_VALIGN_TOP, NULL);