summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThibault Saunier <tsaunier@igalia.com>2019-04-15 16:13:48 -0400
committerThibault Saunier <tsaunier@igalia.com>2019-04-15 16:13:52 -0400
commit3fa393c49877212dba64bb2297a9a6a6d8f1f8cc (patch)
tree1adbb3b6228ae9647d652b8b8f4b4820327695d8
parent81b1368237112188091a4f655706563c5b13d349 (diff)
validate:launcher: Do not copy logs for non flaky tests
That looks weird for users and is incorrect
-rw-r--r--validate/launcher/baseclasses.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/validate/launcher/baseclasses.py b/validate/launcher/baseclasses.py
index 99099fc..b63cad1 100644
--- a/validate/launcher/baseclasses.py
+++ b/validate/launcher/baseclasses.py
@@ -1975,16 +1975,17 @@ class _TestsLauncher(Loggable):
return False
if retry_on_failures:
- if not self.options.redirect_logs:
+ if not self.options.redirect_logs and test.allow_flakiness:
test.copy_logfiles()
printc(test)
- test.clean()
to_retry.append(test)
# Not adding to final report if flakiness is tolerated
to_report = not test.allow_flakiness
if to_report:
self.reporter.after_test(test)
+ if retry_on_failures:
+ test.clean()
if self.start_new_job(tests_left):
jobs_running += 1