summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-10-14Release 2.4.132.4.132.4.xZeeshan Ali2-1/+20
2018-10-14Update issue tracker URLZeeshan Ali1-1/+1
2018-10-14CI: Build with NMEA source enabledZeeshan Ali1-3/+3
2018-10-14CI: Always keep build artifactsZeeshan Ali1-3/+3
2018-10-14CI: Keep all build artifactsZeeshan Ali1-3/+3
2018-10-13CI: Save artifacts on build failureZeeshan Ali1-0/+15
2018-10-13CI: Fetch gettext & ModemManager from distroZeeshan Ali1-5/+1
I'm not sure why we were building these from sources.
2018-10-13CI: no need to checkout geoclueZeeshan Ali1-3/+3
CI already does this for us. Before this change, we were always building the master branch and that meant merge requests weren't getting tested.
2018-10-13conf: Document that all settings are mandatoryZeeshan Ali1-0/+5
Fixes #87.
2018-10-13service: Console message on inactivity timeoutZeeshan Ali1-0/+2
2018-10-13service: Increase agent timeout from 100ms to 20sZeeshan Ali1-2/+4
This should give sufficient amount of time for agents to register themselves before any dbus calls can timeoout (30s by default). Fixes #84.
2018-10-13service: Increase default inactivity timeout to 60sZeeshan Ali1-2/+2
instead of 5 seconds. 5s is very short amount of time when system is very loaded and during startup of a desktop session. There is not harm in waiting 60s anyway. Also, the default value should be longer than the agent registeration timeout, which is currently 100ms but will be increased to 20s in a following patch.
2018-10-13service: Allow disabling of all sources through configZeeshan Ali4-27/+133
Fixes #46.
2018-10-13conf: add elementary-desktop-agent to whitelistworldofpeace1-1/+6
2018-10-13service: Allow absence of agent if agent white-list emptyZeeshan Ali1-8/+17
If no agent is white-listed in the configuration, there is no point in requiring an agent. Fixes #74.
2018-10-13service,config: Internal API to get number of whitelisted agentsZeeshan Ali2-0/+7
2018-10-13conf: Warn about use of Google's servicesZeeshan Ali1-0/+5
2018-08-14Release 2.4.12Zeeshan Ali2-1/+13
2018-07-27build,lib: Respect includedir option in .pc fileBastien Nocera1-1/+1
Fixes #73.
2018-07-25Release 2.4.112.4.11Zeeshan Ali2-1/+23
2018-07-25build: Clean generated vapi files on distcleanZeeshan Ali1-1/+1
2018-06-29agent: Register the agent whenever geoclue startsValentin Blot1-22/+48
The agent watches on d-bus and registers whenever it sees geoclue getting alive. https://gitlab.freedesktop.org/geoclue/geoclue/issues/68
2018-06-29agent: Unimplement unused interface GAsyncInitableValentin Blot3-117/+37
The GAsyncInitable interface that was implemented by the agent was not useful. This commit removes this interface implementation to simplify the code and allow the use of user_data for other things.
2018-06-09service-client: Ensure requested accuracy level is validZeeshan Ali1-5/+37
This fixes a long standing crash resulting from client simply passing an invalid accuracy level. Fixes #58.
2018-05-17Add initial .gitlab-ci.ymlKarl-Philipp Richter1-0/+22
GitLab provides a CI service which allows to test all commit and merge requests automatically on arbitraty Docker images. The initial setup includes building prerequisites which can't be provided with 'apt-get build-dep' and running './autogen.sh && configure && make && make check && make install'.
2018-05-17Add hint about Ubuntu 14.04 build trouble to READMEKarl-Philipp Richter1-0/+7
Add hint about probable trouble on Ubuntu 14.04 because of glib > 2.44.0 requirement to new README section 'Troubleshooting and known limitations'.
2018-05-17Require glib >= 2.44Zeeshan Ali1-1/+1
We need that for using g_autofree() that we just started using.
2018-05-17Merge branch 'wip/tintou/vala' into 'master'Zeeshan Ali4-0/+122
Generate .vapi file for Vala support See merge request geoclue/geoclue!2
2018-05-16Generate .vapi file for Vala supportCorentin Noël4-0/+122
2018-05-06docs: Add gclue_client_get/set_time_threshold()Zeeshan Ali1-0/+2
2018-05-03locator: Fix a potentially unused variable declarationZeeshan Ali1-0/+2
2018-05-03public-api: Fix safety header nameZeeshan Ali1-3/+3
It should be based on the filename.
2018-05-03Release 2.4.102.4.10Zeeshan Ali2-1/+16
2018-05-03Lock down systemd service fileBastien Nocera1-0/+22
Use systemd's service file to lockdown the geoclue daemon to stop eventual security problems. https://bugs.freedesktop.org/show_bug.cgi?id=106190
2018-05-03build,geocode-glib: Remove unused variableBastien Nocera1-2/+0
CACHE_DIR isn't used anywhere. https://bugs.freedesktop.org/show_bug.cgi?id=106190
2018-05-03Revert "client-info: Replace desktop ID detection for new Flatpak"Bastien Nocera2-112/+49
This reverts commit a5afe7a0ee971371423edaca4fdd43b9b7b05a1e, commit c8dc5bc0318293dbc9007946e92a10dba3a57d54 and commit defe4a3e9f4bacba44b12e1fe82dd915e49858c2. The new method of detecting whether an application is a Flatpak is only available to 1) the user running the Flatpak 2) root. As we advise that geoclue is run as a normal non-privileged user, revert those commits while we wait for a solution to be available. See https://github.com/flatpak/flatpak/issues/1644 https://bugs.freedesktop.org/show_bug.cgi?id=97776
2018-05-03service-client: Fix crash on startupBastien Nocera1-1/+4
Make sure to not dereference a NULL StartData when geoclue gets started. https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-05-03D-Bus: Update doc commentZeeshan Ali1-2/+1
Now we require all applications to provide a desktop ID.
2018-05-02Release 2.4.92.4.9Zeeshan Ali2-1/+25
2018-05-02service-client: Minor formatting fixesZeeshan Ali1-12/+16
Lines shouldn't exceed 80 chars.
2018-05-02service-client: Delay "no agent" authorization decisionBastien Nocera1-9/+71
To avoid applications being denied access to location services when gnome-shell hasn't had a chance to register its agent, either because Geoclue got auto-started by the application, or because the shell hasn't finished starting up, delay the authorization check until either an agent appears, or 5 seconds after the application requested the authorization. https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-05-02service-client: Verify 'DesktopId' against Flatpak IDBastien Nocera1-0/+11
And refuse to serve applications that have different values for both. This makes it easier to detect applications which would lie about their IDs when run outside Flatpak, as well as making sure that settings are shared for Flatpak'ed and non-Flatpak'ed versions of the application. https://bugs.freedesktop.org/show_bug.cgi?id=97776
2018-05-02client-info: Replace desktop ID detection for new FlatpakBastien Nocera2-46/+94
For newer (>= 0.6.10) versions of Flatpak, the way to export the desktop ID has changed from requiring cgroups to not requiring it. See https://github.com/flatpak/flatpak/releases/tag/0.6.10 This changes the private gclue_client_info_get_xdg_id() API to return a NULL xdg_id should the code fail to read the Flatpak ID for a Flatpak'ed application, and consider it to be disqualifying: " Like parse_app_info_from_fileinfo(), returns NULL on failure, "" (an empty string) if not sandboxed, and a desktop ID otherwise " https://bugs.freedesktop.org/show_bug.cgi?id=97776
2018-05-02service-client: Split off post agent auth checkBastien Nocera1-32/+48
Separate the authorization checks that happen after the agent availability is checked, to make it possible to delay that portion. https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-05-02service-client: Fix warning with GLib >= 2.56Bastien Nocera1-1/+1
geoclue/src/gclue-service-client.c: In function ‘gclue_service_client_handle_start’: geoclue/src/gclue-service-client.c:574:22: warning: assignment to ‘GClueServiceClient *’ {aka ‘struct _GClueServiceClient *’} from incompatible pointer type ‘GClueDBusClient *’ {aka ‘struct _GClueDBusClient *’} [-Wincompatible-pointer-types] data->client = g_object_ref (client); ^ See https://bugzilla.gnome.org/show_bug.cgi?id=790697 for the gobject change that triggers this warning. https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-05-02Move default timeout to main binaryBastien Nocera3-4/+4
Rather than have the default 5 seconds timeout in 2 separate locations, move the default timeout value to the binary, so as to reduce the difference between the interactive and non-interactive behaviour, and reduce confusion. https://bugs.freedesktop.org/show_bug.cgi?id=106249
2018-04-27Autostart the demo agent by defaultMathieu Bridon2-0/+4
This is necessary for most desktops to continue working as they were before GeoClue required an agent. However, GNOME already has its own agent, which allows authorizing apps individually, and as such doesn't need the demo agent. https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-04-27Build and install the demo agent by defaultMathieu Bridon1-2/+2
Most desktops don't have an agent. As a result, now that GeoClue refuses access without an agent, apps won't be able to obtain the location on those desktops. Installing the demo agent, as long as they start it, keeps things working just the same for those desktops: all accesses will continue being granted. https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-04-27Only install the demo agent desktop file when requestedMathieu Bridon1-2/+5
https://bugs.freedesktop.org/show_bug.cgi?id=106236
2018-04-26service-client: Add a commentZeeshan Ali1-0/+1
To make it clear that accuracy of 0 from agent means geolocation is disabled for the user. https://bugs.freedesktop.org/show_bug.cgi?id=106236