summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHubert Figuiere <hub@figuiere.net>2008-01-23 09:38:41 -0500
committerHubert Figuiere <hub@figuiere.net>2008-01-23 09:38:41 -0500
commit1a47fac30e55d52cc410e14a362fb34098d7bf7f (patch)
tree0093179537b79c4f0eeba7fb23ed0c938d011b34
parent620ad17ee37ec72a4f7acae71bc7a4b3aa4fd046 (diff)
* source/XMPFiles/FormatSupport/GIF_Support.cpp (GIF_Support): Fix
a nasty buffer overflow. Closes Debian #454297. Closes Gnome #484105
-rw-r--r--ChangeLog5
-rw-r--r--NEWS1
-rw-r--r--source/XMPFiles/FormatSupport/GIF_Support.cpp2
3 files changed, 7 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 58b9a11..9d6a409 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-01-23 Hubert Figuiere <hub@figuiere.net>
+
+ * source/XMPFiles/FormatSupport/GIF_Support.cpp (GIF_Support): Fix
+ a nasty buffer overflow. Closes Debian #454297. Closes Gnome #484105
+
2008-01-22 Hubert Figuiere <hub@figuiere.net>
* exempi/xmp.h: Fix a typo. (Closes #14200)
diff --git a/NEWS b/NEWS
index a25ac07..e2a7f32 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,7 @@
- Bug #13712: add --enable-unittest to disable tests.
- Bug: Disable strict aliasing in XMPFiles due to bad casting.
- Bug #14200: fix a typo.
+- Bug: fix a buffer overflow. Closes Debian #454297. Closes Gnome #484105
1.99.7
diff --git a/source/XMPFiles/FormatSupport/GIF_Support.cpp b/source/XMPFiles/FormatSupport/GIF_Support.cpp
index 37149ad..5589f10 100644
--- a/source/XMPFiles/FormatSupport/GIF_Support.cpp
+++ b/source/XMPFiles/FormatSupport/GIF_Support.cpp
@@ -64,7 +64,7 @@ namespace GIF_Support
long headerSize;
long tableSize = 0;
long bytesPerColor = 0;
- unsigned char buffer[256];
+ unsigned char buffer[768];
headerSize = 0;
bytesRead = LFA_Read ( fileRef, buffer, GIF_SIGNATURE_LEN );