summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWill Thompson <will@willthompson.co.uk>2017-07-26 11:49:02 +0100
committerWill Thompson <will@willthompson.co.uk>2017-07-26 11:52:24 +0100
commit975ec1fecbd3ec2ae345edc09fd63ad247ddb97b (patch)
tree1f3510cafaa35fceb09ce7c2de409c73ca8b1e66
parent4fd7e5acd80d94692e36d0781ab1ce170deb9bcc (diff)
appdata: pass appstream-util validate-relax
As mentioned in the Makefile rule, full-on validate fails, because the screenshots are the wrong size. I don't know what the right thing to do is here: I want non-blurry screenshots on hidpi machines.
-rw-r--r--Makefile8
-rw-r--r--data/org.freedesktop.Bustle.appdata.xml.in11
2 files changed, 15 insertions, 4 deletions
diff --git a/Makefile b/Makefile
index 47f3e99..b9db98e 100644
--- a/Makefile
+++ b/Makefile
@@ -37,6 +37,14 @@ org.freedesktop.Bustle.desktop: data/org.freedesktop.Bustle.desktop.in
org.freedesktop.Bustle.appdata.xml: data/org.freedesktop.Bustle.appdata.xml.in
LC_ALL=C intltool-merge -x -u po $< $@
+# https://github.com/flathub/flathub/wiki/Review-Guidelines
+validate-metadata: org.freedesktop.Bustle.desktop org.freedesktop.Bustle.appdata.xml
+ desktop-file-validate org.freedesktop.Bustle.desktop
+ appstream-util validate-relax org.freedesktop.Bustle.appdata.xml
+ # This is only a SHOULD. Screenshots currently violate it because they
+ # are hidpi.
+ appstream-util validate org.freedesktop.Bustle.appdata.xml || true
+
dist/build/bustle-pcap: $(BUSTLE_PCAP_SOURCES) $(BUSTLE_PCAP_HEADERS)
@mkdir -p dist/build
$(CC) -Idist/build/autogen $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) \
diff --git a/data/org.freedesktop.Bustle.appdata.xml.in b/data/org.freedesktop.Bustle.appdata.xml.in
index 25b9aa4..3501987 100644
--- a/data/org.freedesktop.Bustle.appdata.xml.in
+++ b/data/org.freedesktop.Bustle.appdata.xml.in
@@ -4,10 +4,12 @@
<id type="desktop">org.freedesktop.Bustle.desktop</id>
<metadata_license>CC-BY-SA-3.0</metadata_license>
<project_license>LGPL-2.1+ and GPL-2.0+ and GPL-3.0</project_license>
+ <_name>Bustle</_name>
+ <_summary>Draw sequence diagrams of D-Bus activity</_summary>
<description>
<!-- Translators: These are the application description paragraphs in the AppData file. -->
- <_p>Bustle draws sequence diagrams of D-Bus activity.</_p>
- <_p>It shows signal emissions, method calls and their
+ <_p>Bustle draws sequence diagrams of D-Bus activity.
+ It shows signal emissions, method calls and their
corresponding returns, with time stamps for each individual
event and the duration of each method call. This can help
you check for unwanted D-Bus traffic, and pinpoint why your
@@ -25,8 +27,9 @@
<_image type="source">https://wiki.freedesktop.org/www/Software/Bustle/bustle-0.5.2-2.png</_image>
</screenshot>
</screenshots>
- <url type="homepage">http://willthompson.co.uk/bustle/</url>
- <updatecontact>philip_at_tecnocode.co.uk</updatecontact>
+ <url type="homepage">https://www.freedesktop.org/wiki/Software/Bustle/</url>
+ <updatecontact>will_at_willthompson.co.uk</updatecontact>
+ <translation type="gettext">bustle</translation>
<provides>
<id>bustle.desktop</id>
</provides>