From e27141fb9087988db6f95f413850d362ad141856 Mon Sep 17 00:00:00 2001 From: Frederic Martinsons Date: Tue, 15 Jun 2021 13:01:49 +0200 Subject: tools: suppress duplicate state change in deactivation step of active connection Signed-off-by: Frederic Martinsons --- tools/test-networkmanager-service.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/test-networkmanager-service.py b/tools/test-networkmanager-service.py index 66af0ede44..db380d0a99 100755 --- a/tools/test-networkmanager-service.py +++ b/tools/test-networkmanager-service.py @@ -1489,10 +1489,6 @@ class ActiveConnection(ExportedObj): def start_deactivation(self): assert self._deactivation_id is None - self._set_state( - NM.ActiveConnectionState.DEACTIVATING, - NM.ActiveConnectionStateReason.USER_DISCONNECTED, - ) self.device.set_state( NM.DeviceState.DEACTIVATING, NM.DeviceStateReason.USER_REQUESTED ) -- cgit v1.2.3 From 8dc64c7bddb0135a12c1a1e4cefc959407d227a6 Mon Sep 17 00:00:00 2001 From: Frederic Martinsons Date: Tue, 15 Jun 2021 18:33:14 +0200 Subject: tools: correct NetworkManager top object set_state function Signed-off-by: Frederic Martinsons --- tools/test-networkmanager-service.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/test-networkmanager-service.py b/tools/test-networkmanager-service.py index db380d0a99..0f4e6b0f53 100755 --- a/tools/test-networkmanager-service.py +++ b/tools/test-networkmanager-service.py @@ -1562,8 +1562,8 @@ class NetworkManager(ExportedObj): pass def set_state(self, new_state): - self._dbus_property_set(IFACE_NM, PRP_NM_STATE, state) - self.StateChanged(dbus.UInt32(self.state)) + self._dbus_property_set(IFACE_NM, PRP_NM_STATE, new_state) + self.StateChanged(dbus.UInt32(new_state)) @dbus.service.method(dbus_interface=IFACE_NM, in_signature="", out_signature="ao") def GetDevices(self): -- cgit v1.2.3